search

whatwg / urlpattern

URL Pattern Standard
https://urlpattern.spec.whatwg.org/
Other
157 stars 22 forks source link

Use exclusive substring in make component string #130

Closed lucacasonato closed 3 years ago

lucacasonato commented 3 years ago

Chromium implementation uses an exclusive substring: https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/modules/url_pattern/url_pattern_parser.cc;l=454-455;drc=7bd7edac514e6a13820d9982afaa8a5102bd7688

Preview | Diff

wanderview commented 3 years ago

Unfortunately the code point substring that is linked to in infra is inclusive. @domenic, what do you think the best way to fix this would be?

domenic commented 3 years ago

Just adding − 1 seems relatively clean.