search

whatwg / urlpattern

URL Pattern Standard
https://urlpattern.spec.whatwg.org/
Other
157 stars 22 forks source link

Updates the regular expression to work with the `v` flag instead of `u` #188

Closed sisidovski closed 1 year ago

sisidovski commented 1 year ago

Updates the regular expression part to work with v flag instead of u.

This will fix #178.

Preview | Diff

jeremyroman commented 1 year ago

nit: no period at the end of the first line, per https://github.com/whatwg/meta/blob/main/COMMITTING.md#commit-messages

I'd probably remove the "this PR" bit from the final commit message since at that point it's not a PR, and the rest repeats the first line.

domenic commented 1 year ago

Nice! Consider filing a Chromium bug to implement this :)

sisidovski commented 1 year ago

Filed! crbug.com/1482263