Closed domenic closed 10 months ago
The build will fail until we run spec-factory to update the Makefile, etc.; that will be a separate pull request. (Which we can merge before this one.)
Running spec-factory would be good because then PR Preview works and we can see what the document ends up looking like, right?
Yeah, I'll try to land that first, but I think that depends on db.json.
Looks fine on inspection, but a preview would be nice. :)
I think a preview is not possible because PR preview is using the old config file against the new spec, or something like that, and thus fails the whole process when it can't generate the old spec in order to create diffs.
In lieu of that I've set up a preview here: https://boom-bath.glitch.me/urlpattern-preview.html
Editor review especially appreciated for changes to spec.bs.
The standard is live! https://urlpattern.spec.whatwg.org/
Part of #190. See also https://github.com/whatwg/sg/issues/215.
I'd like editor review and also @annevk review if possible.
:boom: Error: 400 Bad Request :boom:
PR Preview failed to build. (Last tried on Oct 18, 2023, 5:54 AM UTC).
More
PR Preview relies on a number of web services to run. There seems to be an issue with the following one: :rotating_light: [CSS Spec Preprocessor](https://api.csswg.org/bikeshed/) - CSS Spec Preprocessor is the web service used to build Bikeshed specs. :link: [Related URL](https://api.csswg.org/bikeshed/?url=https%3A%2F%2Fraw.githubusercontent.com%2Fwhatwg%2Furlpattern%2F13b8b1464ec873dab131332035707adba66a8bb0%2Fspec.bs&md-warning=not%20ready) ``` Error running preprocessor, returned code: 2. FATAL ERROR: Found unmatched text macro [COMMIT-SHA]. Correct the macro, or escape it with a leading backslash. ✘ Did not generate, due to errors exceeding the allowed error level. ``` _If you don't have enough information above to solve the error by yourself (or to understand to which web service the error is related to, if any), please [file an issue](https://github.com/tobie/pr-preview/issues/new?title=Error%20not%20surfaced%20properly&body=See%20whatwg/urlpattern%23193.)._