search

whatwg / urlpattern

URL Pattern Standard
https://urlpattern.spec.whatwg.org/
Other
160 stars 22 forks source link

Fix property descriptions in the quick reference #194

Closed zcorpan closed 1 year ago

jeremyroman commented 1 year ago

Looks reasonable to me (well, we could bikeshed scheme/protocol, path/pathname and hash/fragment, but it probably doesn't matter in this context). Unfortunately I seem to not have been granted permission to review PRs since this was moved into whatwg.

@domenic do you know what's required for that?

domenic commented 1 year ago

https://github.com/whatwg/urlpattern/issues/195 might be relevant here.

Yes, both of you have the same permissions; Jeremy please try again?

jeremyroman commented 1 year ago

I was able to approve, but I'm still not authorized to merge PRs due to branch protection.

domenic commented 1 year ago

I found a setting that seemed different between this and other standards. Give it a shot now?