whatwg / urlpattern

URL Pattern Standard
https://urlpattern.spec.whatwg.org/
Other
159 stars 22 forks source link

Correct processing of non-string members of a base URL record #203

Closed jeremyroman closed 10 months ago

jeremyroman commented 10 months ago

Some of these values may be null (or in the case of port, an integer) and must be converted to strings before they can be applied to URLPatternInit.

The conversion of the port to an integer is also necessary in the encoding callbacks.

Addresses #202, at least in part.

(See WHATWG Working Mode: Changes for more details.)


Preview | Diff

jeremyroman commented 10 months ago

@annevk I think we need a second implementer interest even for little fixes like this, right? Is WebKit cool with this?

annevk commented 10 months ago

I think for cases where you are just fixing a bug in the standard when there are no conflicting implementations out there you can use your best judgment and carry on.

Though perhaps the extra waiting time helps as I see you fixed another another nit. :-)

Anyway, looks good.

jeremyroman commented 10 months ago

Thanks Anne, noted for future changes in this vein.