Currently, some steps in "initialize a URLPattern" access potentially nonexistent entries in the processedInit map, and expect "compile a component" to receive these as null, even though it requires a string.
Instead, these entries are now always populated after calling "process a URLPatternInit" so that subsequent steps can depend on a valid string.
Since the comparison with the default port requires that the two types be the same, fix that too.
Fixes #209.
[x] At least two implementers are interested (and none opposed):
Google Chrome
n/a (change is simply fixing a bug in a non-controversial way, per this comment)
[x] Tests are written and can be reviewed and commented upon at:
n/a (this is a fix to how the spec expresses this, but does not represent a behavior change, and existing tests cover this behavior)
PR Preview failed to build. (Last tried on Jan 26, 2024, 8:28 PM UTC).
More
PR Preview relies on a number of web services to run. There seems to be an issue with the following one:
:rotating_light: [CSS Spec Preprocessor](https://api.csswg.org/bikeshed/) - CSS Spec Preprocessor is the web service used to build Bikeshed specs.
:link: [Related URL](https://api.csswg.org/bikeshed/?url=https%3A%2F%2Fraw.githubusercontent.com%2Fjeremyroman%2Furlpattern%2F4d880bca59fca992264b669d4086b78904c5cd31%2Fspec.bs&force=1&md-status=LS-PR&md-Text-Macro=PR-NUMBER%20214)
_If you don't have enough information above to solve the error by yourself (or to understand to which web service the error is related to, if any), please [file an issue](https://github.com/tobie/pr-preview/issues/new?title=Error%20not%20surfaced%20properly&body=See%20whatwg/urlpattern%23214.)._
jeremyroman
commented
9 months ago
Currently, some steps in "initialize a URLPattern" access potentially nonexistent entries in the processedInit map, and expect "compile a component" to receive these as null, even though it requires a string.
Instead, these entries are now always populated after calling "process a URLPatternInit" so that subsequent steps can depend on a valid string.
Since the comparison with the default port requires that the two types be the same, fix that too.
Fixes #209.
(See WHATWG Working Mode: Changes for more details.)
:boom: Error: 400 Bad Request :boom:
PR Preview failed to build. (Last tried on Jan 26, 2024, 8:28 PM UTC).
More
PR Preview relies on a number of web services to run. There seems to be an issue with the following one: :rotating_light: [CSS Spec Preprocessor](https://api.csswg.org/bikeshed/) - CSS Spec Preprocessor is the web service used to build Bikeshed specs. :link: [Related URL](https://api.csswg.org/bikeshed/?url=https%3A%2F%2Fraw.githubusercontent.com%2Fjeremyroman%2Furlpattern%2F4d880bca59fca992264b669d4086b78904c5cd31%2Fspec.bs&force=1&md-status=LS-PR&md-Text-Macro=PR-NUMBER%20214) _If you don't have enough information above to solve the error by yourself (or to understand to which web service the error is related to, if any), please [file an issue](https://github.com/tobie/pr-preview/issues/new?title=Error%20not%20surfaced%20properly&body=See%20whatwg/urlpattern%23214.)._