Remove JavaScript realm dependency

yoshisatoyanagisawa commented 9 months ago

To allow the algorithms in the specification to be used outside of JavaScript, we need to remove dependency to JavaScript realm.

This CL make a URLPattern object associated with an underlying URL Pattern struct, and makes algorithms to use it instead.

[x] At least two implementers are interested (and none opposed):
- Google Chrome
- n/a (change is simply fixing an issue in a non-controversial way).
[x] Tests are written and can be reviewed and commented upon at:
- n/a (this is a fix to how the spec express this, there is no behavior change, and existing tests cover this behavior)
[x] Implementation bugs are filed:
- Chromium: n/a (no behavior change is required)
- Gecko: https://bugzilla.mozilla.org/show_bug.cgi?id=1731418 (vendor does not yet implement the spec)
- WebKit: n/a (no reason to believe a change is required)
- Deno: n/a (no reason to believe a change is required)
- kenchris/urlpattern-polyfill: n/a (no reason to believe a change is required)
[x] MDN issue is filed: n/a (change is on a spec detail not expressly documented)
[x] The top of this comment includes a clear commit message to use.

yoshisatoyanagisawa commented 9 months ago

@jeremyroman @sisidovski @domenic Can I ask you to take a look?

yoshisatoyanagisawa commented 9 months ago

To remove JavaScript realm, you also have to update 4.1. Integrating with JavaScript APIs not to accept realm and build URL Pattern with create?

Yes. I tried to update them to eliminate realm dependencies.

yoshisatoyanagisawa commented 9 months ago

Thanks for the review, @sisidovski.

@jeremyroman @domenic Will you take a look?

yoshisatoyanagisawa commented 9 months ago

@domenic Thanks for the review. I have addressed your comments.

yoshisatoyanagisawa commented 9 months ago

Thanks @jeremyroman for the review. @domenic Will you take another look at the PR?

yoshisatoyanagisawa commented 9 months ago

@domenic Thank you for the review!

Will somebody merge this PR? Thank you in advance.

whatwg / urlpattern