whatwg / urlpattern

URL Pattern Standard
https://urlpattern.spec.whatwg.org/
Other
157 stars 22 forks source link

Remove JavaScript realm dependency #219

Closed yoshisatoyanagisawa closed 8 months ago

yoshisatoyanagisawa commented 8 months ago

To allow the algorithms in the specification to be used outside of JavaScript, we need to remove dependency to JavaScript realm.

This CL make a URLPattern object associated with an underlying URL Pattern struct, and makes algorithms to use it instead.

Fixes https://github.com/whatwg/urlpattern/issues/217

(See WHATWG Working Mode: Changes for more details.)


Preview | Diff

yoshisatoyanagisawa commented 8 months ago

@jeremyroman @sisidovski @domenic Can I ask you to take a look?

yoshisatoyanagisawa commented 8 months ago

To remove JavaScript realm, you also have to update 4.1. Integrating with JavaScript APIs not to accept realm and build URL Pattern with create?

Yes. I tried to update them to eliminate realm dependencies.

yoshisatoyanagisawa commented 8 months ago

Thanks for the review, @sisidovski.

@jeremyroman @domenic Will you take a look?

yoshisatoyanagisawa commented 8 months ago

@domenic Thanks for the review. I have addressed your comments.

yoshisatoyanagisawa commented 8 months ago

Thanks @jeremyroman for the review. @domenic Will you take another look at the PR?

yoshisatoyanagisawa commented 8 months ago

@domenic Thank you for the review!

Will somebody merge this PR? Thank you in advance.