search

whatwg / urlpattern

URL Pattern Standard
https://urlpattern.spec.whatwg.org/
Other
157 stars 22 forks source link

Editorial: Add proper serialization of URL properties #224

Closed rubycon closed 6 months ago

rubycon commented 7 months ago

This PR fix missing serialization steps of internal port and host properties in the spec. The URL parser return port as an integer and host as either a hostname string, an integer (IPv4 address) or an array of integers (IPv6 address). For further processing by the URLPattern code these properties need to be properly converted to string.

The issue was discussed here: https://github.com/whatwg/urlpattern/issues/202#issuecomment-1937770488

Preview | Diff

jeremyroman commented 7 months ago

Thanks for the pull request. Only a couple things before I can merge it.

  1. Please amend the commit message according to meta/COMMITTING.md. In particular, the first line should probably be marked as "Editorial" (which lets us avoid many of the usual checks) and be written in the imperative. I can do this when merging it need be.
  2. You need to be covered by an appropriate participation agreement which applies to at least the URL workstream.
rubycon commented 7 months ago

@jeremyroman I updated my PR title and submitted a participant agreement, waiting for its validation.

jeremyroman commented 6 months ago

The WHATWG page says:

@rubycon has signed up to participate as an individual, but has not yet been verified. Hold tight while we sort this out on our end!

@annevk do you know what need to be done for it to be "verified"? I'm not super familiar with how individual participation works.

domenic commented 6 months ago

https://github.com/whatwg/participate.whatwg.org#process-for-editors :)

jeremyroman commented 6 months ago

Gotcha; done. (Was that linked from the check status page? If so, I missed it.)