search

whatwg / webidl

Web IDL Standard
https://webidl.spec.whatwg.org/
Other
406 stars 164 forks source link

No mixin [NoInterfaceObject] usage #430

Open annevk opened 7 years ago

annevk commented 7 years ago

Per https://github.com/heycam/webidl/pull/423#issuecomment-326332460 this exists. I'd like to study such usage and see if we can get rid of it.

tobie commented 7 years ago

Here's a manually filtered list I build for #363 based on running awk on Gecko's src files:

annevk commented 7 years ago

Thanks, seems like we could just drop the keyword from those and be done with it. I guess part of the problem is some of those specifications not being maintained, but that can be fixed one way or another.

tobie commented 7 years ago

Well, we'd want to make sure suddenly exposing these interfaces to the Web doesn't break stuff, no?

annevk commented 7 years ago

Yeah, I suppose the ones with overly generic names should be prefixed, but seems safe otherwise.

tobie commented 7 years ago

Prefixing is an observable change. No idea if it would have real impact, though.

annevk commented 7 years ago

How is it observable?

tobie commented 7 years ago 
navigator.geolocation.getCurrentPosition(p => console.log(Object.prototype.toString.call(p)));
// [object Position]
annevk commented 7 years ago

Sigh. Part of the reason we had [NoInterfaceObject] was the ability to ship objects and change the name later. I guess that's another reason we should really get rid of it (and decide on names we can live with upfront).

annevk commented 5 years ago

WebGL seems fixed. I filed issues against two other specifications I identified from the list above. Anything else?

domenic commented 5 years ago

Searching through Blink, External in the HTML spec needs fixing. There's also https://github.com/w3c/mediacapture-main/issues/501 which is weird.

domenic commented 5 years ago

Also https://w3c.github.io/webappsec-feature-policy/#featurepolicy ... a little hard to tell since Blink doesn't have interface mixin syntax yet, so lots of stuff is mixed together.

bzbarsky commented 5 years ago

Fwiw, that's why I haven't looked at this in Gecko either. It'll be a lot simpler once we implement mixin syntax...