search

whatwg / whatwg.org

The WHATWG website and other static resources
https://whatwg.org/
Other
75 stars 50 forks source link

Add Bikeshed's style-dfn-panels styles to standard.css #343

Closed andreubotella closed 3 years ago

andreubotella commented 3 years ago

This change additionally modifies a few rules from Bikeshed's styles for integration with the dfn panels in the HTML spec.

See tabatkins/bikeshed#1772, which turns off Bikeshed's style-dfn-panels styles, and whatwg/html#5947, which modifies HTML's html-dfn.js script to work with these styles.

annevk commented 3 years ago

Thanks for working on this. Can we merge this without merging the HTML change or will HTML be badly impacted if we do that?

andreubotella commented 3 years ago

Thanks for working on this. Can we merge this without merging the HTML change or will HTML be badly impacted if we do that?

Merging this before the HTML change is fine, since the HTML panels use different classes than Bikeshed's (Bikeshed's dfn-panel is HTML's dfnPanel, and HTML has no equivalent of Bikeshed's dfn-paneled).

However, since @sideshowbarker has raised concerns in whatwg/html#5947 about the way I've changed the way the dfn panels are positioned in the HTML spec, it's probably best to wait until that's resolved, so the styles can be adjusted.