search

whatwg / xhr

XMLHttpRequest Standard
https://xhr.spec.whatwg.org/
Other
314 stars 131 forks source link

The open() method's "async" argument is now invalid per IDL #251

Closed tabatkins closed 4 years ago

tabatkins commented 5 years ago

Since the async iterator<> feature was added to WebIDL, async now tokenizes as a keyword, not an ident, and thus is invalid as an argument name. You need to prefix it with a _, like _async.

annevk commented 5 years ago

Will https://github.com/heycam/webidl/pull/769 fix this @saschanaz?

tabatkins commented 5 years ago

Assuming the edits in that PR are valid, yes it does.

saschanaz commented 5 years ago

It does not solve this because it only covers operations and attributes. I can modify the PR to cover this.

annevk commented 5 years ago

Do we still need a Bikeshed or widlparser update? #252 is failing to build at the moment because of this (I think).

foolip commented 5 years ago

The Bikeshed change that introduced this was https://github.com/tabatkins/bikeshed/commit/450e0499b28bb4c684052ad936ad1e7d36c4eac5, and the Travis build for it did fail: https://travis-ci.org/tabatkins/bikeshed/builds/569899644

Changes around the open() method show up in the diff.

I think Bikeshed needs an update, so I've filed https://github.com/tabatkins/bikeshed/issues/1507 for that, and https://github.com/tabatkins/bikeshed/issues/1506 for process which allowed for the regression.

foolip commented 5 years ago

I've sent https://github.com/tabatkins/bikeshed/pull/1509 and confirmed that fixes the problem with make local for this spec.

annevk commented 4 years ago

This was resolved some time ago \o/