Closed Rashika101 closed 3 years ago
Hey, thanks, the patch looks perfect! A few nits for the description, could you:
[x ]
so that it can be [x]
. You'll see it magically becoming a checkbox!Fixes #305
at the top line. Doing so will show this patch in the issue so that other's won't duplicate your work 😉Is that okay? Yes,The checkbox has been created.. But in 1st point title modification what is that?Isn't similar?
You'll see the Edit button next to the Open with button, please click it and you can edit the title 😊
BTW, you need to sign the Participation Agreement for your contribution, please go here and do the required steps. Sorry for the unexpected paperwork 😬
After that, during workdays someone will review this once more and merge it. Thank you for your hard work 😍
Thank you @saschanaz Modified the title!! Explain a little more on participation agreement ,what are the steps i need to take in that agreement... When I am submitting ,"Invalid entity name name " is coming..
Entity name? I think you are supposed to fill only the "If signing as an Individual" form 👀 (unless you are doing this as a part of your job).
And thank you for setting the right title! It would be even better without the quotes.
Thank You @saschanaz Quotes removed... Signed the Participation agreement. When my PR will merge? and still my participation showing pending..
Per this page it needs to be verified by the admins, which will happen probably next week. Hold tight 😉
Also, you should feel free to add your name to the Acknowledgments section.
@annevk Is there any changes i have to make?
@saschanaz Thank You for your guidance!! Is there any thing else that i have to do?
@Rashika101 yeah, instead of Window,DedicatedWorker,SharedWorker,ServiceWorker
you want Window,Worker
. And you can also add your name to the Acknowledgments section at the bottom of the document if you wish.
To reduce confusion: Worker
is a shorter equivalent of DedicatedWorker,SharedWorker,ServiceWorker
. We want to make the code short as possible to make it more manageable, and thus [Exposed=(Window,Worker)]
is preferred here. Sorry for confusing you 🙏
Feel free to ping me when you need any more help 💕
@saschanaz @annevk I did the changes as per your guidance. A new patch and pull request has been created... Did I had done it correctly? Please recheck it. Thanks!
Hmm, you don't have to create new patch, you can edit existing patch by Files changed -> "..." button (next to xhr.bs) -> Edit file. But that also works 👀
Should I do it again now in this patch? As you say...
I'd say please give it a try 😁
Done.....Is that visible?
Yup, perfectly splendid!
Thank You...Any change required in title?
No, the patch still does the same work, just in a shorter way 😀
BTW, have you considered adding your name to Acknowledgments? We totally want to list the contributors who gave valuable patch(es) and you also deserve it! It's not a requirement, so feel free to ignore it.
Yes, i want to add name...How to do that?
It's same, in the same file search "Acknowledgments" and you'll see several names ordered in alphabetical way. Please add your name there 😉
Excuse me.....feeling stupid Didn't get acknowledgement...
Oh, it's "Acknowledgments" (it lacks "e" between "legd" and "ments", English is weird 😄)
Sorry..... Where do I search it?
In the xhr.bs file, the one you just edited. Make sure you tap Control+F (Or Command+F if you are on macOS) after you click the text editor or you won't see anything.
Oh I mean,
I did it in the same way. But nothing happens.
Could you explain what you saw on the screen when you tried it? Did you fail to find the names?
When I search "Ackno" nothing comes up..
Did you click the text editor before searching? It works in a bit weird way, it may not come up if you didn't.
(It's sad that we couldn't ship FindText API to make this straightforward.)
Is there any other way to do so? I am trying but nothing happens.
Hmm, alternatively you can just scroll down to line number 1911 (the number you see at the left of the text editor) and it's there.
Oh,Thank You so much. I did it. Anything else i need to do.
Good! Could you move your name before Robin Berjon so that the list can be alphabetically ordered? (so that Rashika comes before Robin)
Oh excuse me. Done.
Okay, now everything is perfect and we can just wait for the verification for your participation form. Thank you! 🎉🎉
Thank you. Until we can work on other issues.?
I guess no good first issue anymore in this repository. I think issues in whatwg generally require some knowledge of web standards than others (this one was luckily exceptional 😁) , so you may want to try other repositories too. @annevk may have some thought, though.
Fixes #305 "Expose ProgressEvent to ServiceWorker"
(See WHATWG Working Mode: Changes for more details.)
Preview | Diff