search

whatwg / xhr

XMLHttpRequest Standard
https://xhr.spec.whatwg.org/
Other
314 stars 129 forks source link

Resource Timing integration #319

Closed noamr closed 2 years ago

noamr commented 3 years ago

When response is a network error or body is fully read, finalize and report the response.

Depends on https://github.com/whatwg/fetch/pull/1185

See: https://github.com/w3c/resource-timing/pull/261 and https://github.com/w3c/resource-timing/issues/252

Preview | Diff

Preview | Diff

annevk commented 3 years ago

Note that the string formatting comment still stands I think.

noamr commented 2 years ago

@annevk I think this should be OK now, in conjunction with the FETCH handling of network errors.

noamr commented 2 years ago

@annevk: revised to align with how FETCH handles network errors. Basically we need to report in all of the network-error cases ("handle errors"), and in the "end of body" case when there is no error. In both cases we report to the timeline before any other reporting (e.g. exception) is done.

noamr commented 2 years ago

@annevk: revised to align with how FETCH handles network errors. Basically we need to report in all of the network-error cases ("handle errors"), and in the "end of body" case when there is no error. In both cases we report to the timeline before any other reporting (e.g. exception) is done.

@annevk this has been ready for a while for a review. Could you take a look when you get a chance?