Closed sideshowbarker closed 3 years ago
Thanks, you'll also need to remove the instance of sync-xhr elsewhere.
Thanks, you'll also need to remove the instance of sync-xhr elsewhere.
So, I’ll raise a PR against the Permissions Policy spec to drop or change that.
But note also, the Permissions Policy has an example with this:
const new_frame = document.createElement('iframe');
new_frame.allow = 'sync-xhr';
// This will be true, as the iframe is allowed to use sync-xhr at whatever URL is
// mentioned in its src attribute, even though that attribute is not yet set.
const is_sync_xhr_allowed = new_frame.featurePolicy.allowsFeature('sync-xhr');
https://w3c.github.io/webappsec-permissions-policy/#example-92e8a40f
So, I guess I’ll need replace that example with something else. Suggestion welcome.
I didn't mean that, sorry, I meant the step in https://xhr.spec.whatwg.org/#dom-xmlhttprequest-send (which is why the build is failing). But if you want to take the other bits on as well, sounds good to me. 😊
A good example of a Permissions Policy would be camera
or geolocation
.
I didn't mean that, sorry, I meant the step in xhr.spec.whatwg.org/#dom-xmlhttprequest-send (which is why the build is failing).
ah OK — pushed a commit to drop that step
But if you want to take the other bits on as well, sounds good to me. 😊
A good example of a Permissions Policy would be
camera
orgeolocation
.
Thanks — I’ll raise a PR against the Permissions Policy spec to change the example/reference there to one of those
For the sync-xhr
references in the Permissions Policy spec, I just raised an issue https://github.com/w3c/webappsec-permissions-policy/issues/419
@sideshowbarker thanks! It seems this needs an update to MDN as well as it currently references XHR for this?
Ah, that was resolved by https://github.com/mdn/browser-compat-data/commit/bcc150faf0fbaa2a54f87cb0e60e5a2d85e0a1ed.
Ah, that was resolved by mdn/browser-compat-data@bcc150f.
Yeah but actually there are some other changes we can make to mdn/content; I’ll raise a PR there too
See https://github.com/whatwg/xhr/pull/321 and https://github.com/whatwg/xhr/pull/295
Preview | Diff