search

whatyouhide / redix

Fast, pipelined, resilient Redis driver for Elixir. 🛍
http://hexdocs.pm/redix
MIT License
1.1k stars 122 forks source link

Silent crash of whole application when redix has password configured for redis with auth disabled #243

Closed JuniorJPDJ closed 1 year ago

JuniorJPDJ commented 1 year ago

I had hard time debugging this today.

Redix is crashing whole app when we provide redis password for redix and there's no configured password/auth on redis side. When it would be ok, there's no error thrown or logged so debugging was pain.

whatyouhide commented 1 year ago

@JuniorJPDJ can you provide an small reproducing example, maybe using Docker?

jpruciak commented 1 year ago

I'm not erlang/elixir programmer, but I suspect you know how to log into redis using your library ;)

Normal redis server container running doesn't automatically enable auth, so just start redis docker container and try to connect to this redis server using correct host, port and provide random password (any). It should crash silently.

We are using ~1.1.5 redix version.

whatyouhide commented 1 year ago

I suspect you know how to log into redis using your library

No need for snark 🙃

I added an explicit log when disconnecting in 1b79c4219059e67dd5655ff00d32e5154ade7447.

jpruciak commented 1 year ago

No need for snark 🙃

I meant I don't really know but you probably can figure it out :D Nothing mean from my side.

Thank you for fix!