Client-side caching in `Redix.PubSub` uses admin Redis command

whatyouhide / redix

Fast, pipelined, resilient Redis driver for Elixir. 🛍

http://hexdocs.pm/redix

MIT License

1.1k stars 122 forks source link

Client-side caching in `Redix.PubSub` uses admin Redis command #262

Closed chess4ever closed 8 months ago

chess4ever commented 8 months ago

We are using Redis6 for our pubsub and we have this ACL in place +@all -@dangerous -@admin for security reasons. The problem is that the new client side caching feature release in version 1.4.0 uses the CLIENT ID command that is an admin command.

Would it be possible to avoid using that command? Or otherwise, would it be possible to opt out from the feature?

whatyouhide commented 8 months ago

Hi @chess4ever yes we can totally make that optional. Do you want to send a PR? Ideally, we can have a :client_id boolean option to Redix.PubSub.start_link/1 and return an error from Redix.PubSub.get_client_id/1 if the option was false.

whatyouhide commented 8 months ago

Release v1.4.1.