search

whatyouhide / vim-gotham

Code never sleeps in Gotham City. 🌃
MIT License
1.25k stars 80 forks source link

yellow color seems out of place in Gotham color pallet #23

Closed alexanderjeurissen closed 7 years ago

alexanderjeurissen commented 8 years ago

This especially shows in the Airline theme when going in insert mode. Compared with the color hue's used in other parts of the UI and compared to the colors for normal and visual mode (bright yellow, and green respectively) the yellow color just seems off, lowering the saturation of the color helps but doesn't solve it completely.

below two screenshots that illustrate this, side note: I use the Gotham ergo theme for Iterm.

the insert mode yellow:

screen shot 2016-01-30 at 18 49 44

The profile overview of the Gotham ergo theme, note that the yellow color is the same in all iterm colors chemes:

screen shot 2016-01-30 at 19 02 52

I'm curious as to what your opinion is on the mather and how this yellow color came about.

whatyouhide commented 8 years ago

@alexanderjeurissen I have absolutely no design knowledge of any kind so I basically just put together a bunch of colors that made sense to me together :). You may be right, the yellow could indeed look a little off. If you have any suggestions, I'm very open to them!

alexanderjeurissen commented 8 years ago

maybe using the bright red color in the airline theme instead of yellow. I'm not sure how that would look though so I'll have to try that out.

Is the yellow color used anywhere else besides the airline theme insert mode ? otherwise we could replace it with another color. I'll also have a go at experimenting with the saturation of the yellow color maybe I can tweak it into awesomeness.

whatyouhide commented 8 years ago

I haven't worked hands on on gotham for a while now, so I'm not sure if yellow is used only in the airline theme. Not sure about red in the airline theme, as red looks error-y and I'm not sure that would be good.

Maybe toying with the saturation of yellow is a safe approach if you manage to make it "keep the spirit" of gotham, whatever that means :D

alexanderjeurissen commented 8 years ago

@brucewayne what is your take on this ?

alexanderjeurissen commented 8 years ago

lol that username actually exists XD

whatyouhide commented 8 years ago

:smile:

alexanderjeurissen commented 8 years ago

I did some more research but changing the yellow hue / brightness only makes it weird compared to the green en orange colors which are also more "pastel" like.

I've also noticed the the yellow color is used in other places tmux uses yellow by default in the menus for example.I think that the best solution is changing the airline theme colors and not solve this in the terminal theme.

I also found another use for the yellow color as can be seen in my new tmux status line which fits in quite nicely with the rest of Gotham :smile: screen shot 2016-02-06 at 01 26 46

long story short, I'll have a look at the airline theme colors and will update this issue if I find a solution or give up ;)

whatyouhide commented 8 years ago

Sounds like a plan :+1:

jayniz commented 8 years ago

I also found another use for the yellow color as can be seen in my new tmux status line which fits in quite nicely with the rest of Gotham

@alexanderjeurissen wanted to ask what that neat, tmux status line is. then thought the guy might have his dotfiles on github. and indeed, he does. 👌thank you!

whatyouhide commented 7 years ago

Closing this in favor of #26.