search

whatyouhide / vim-gotham

Code never sleeps in Gotham City. 🌃
MIT License
1.24k stars 79 forks source link

Don't use the "bright" colors in :terminal #30

Closed keremc closed 8 years ago

keremc commented 8 years ago

Gotham, like many other color schemes (such as base16 and solarized) that try to support 16-color terminals , "abuses" the bright terminal colors (terminal colors 8-15) to function. For example, it expects color 10 (Bright Green) to be a color (#091f2e) that is neither very green nor bright. This causes some terminal applications to look weird since they expect the bright colors to be bright :stuck_out_tongue:. With this patch neovim's :terminal ignores the colors 8-15 from gotham's palette and re-uses colors 0-7 instead.

whatyouhide commented 8 years ago

I don't really know the effect of bright colors in :terminal, could you show a before/after screenshot? :) Thanks for contributing btw! 💟

keremc commented 8 years ago

Terminal applications use bright colors to draw user's attention and highlight something, gotham uses bright colors for its UI. For example, here is a screenshot of ag running in :terminal. Ag uses the color Bright Green for the name of the matching file to highlight it. Since the color that is assigned to Bright Green in gotham's palette is anything but bright, it has the opposite effect (the file name becomes very easy to miss).

Before: before After: after

With this patch :terminal uses the same color for Green and Bright Green.

whatyouhide commented 8 years ago

Alrighty, looks good :) Thanks!