search

whatyouhide / vim-gotham

Code never sleeps in Gotham City. 🌃
MIT License
1.25k stars 80 forks source link

Buffer name text too dark #38

Closed aalvarado closed 7 years ago

aalvarado commented 7 years ago

Changes introduced here: https://github.com/whatyouhide/vim-gotham/pull/26

I feel that the text on the buffer name (tab file name) is too dark.

(with transparency) screen shot 2017-03-22 at 9 09 42 am

screen shot 2017-03-22 at 9 10 28 am

Screenshot from the README:

687474703a2f2f692e696d6775722e636f6d2f4e66527548464e2e706e67

I feel the last screenshot shows better colors for filenames. Is this something that anyone else is experiencing?

I've been having a hard time switching through tabs since my brain takes a bit more to try and identify the filename, before it was very quick, now my eyes dance a bit around the tab to read the name.

thanks!

whatyouhide commented 7 years ago

@alexanderjeurissen #23 did not include screenshots of the tab bar, is this change intended?

alexanderjeurissen commented 7 years ago

@whatyouhide that was definitely not intended, I rarely used vim tabs back when I introduced that change and didn't test for this regression. I'll take a look this weekend.

whatyouhide commented 7 years ago

@alexanderjeurissen awesome, thanks a lot 💟

alexanderjeurissen commented 7 years ago

@whatyouhide Didn't get around to looking into this issue this weekend, I'll update this issue when I've come up with a fix.

whatyouhide commented 7 years ago

Closed via #43.