search

whatyouhide / xandra

Fast, simple, and robust Cassandra/ScyllaDB driver for Elixir.
ISC License
396 stars 54 forks source link

Add support for native protocol v4 #134

Closed jvf closed 5 years ago

jvf commented 5 years ago

According to #109 and the README.md native protocol v3 and v4 are supported by Xandra.

Looking through the source code I cannot find any implementation of native protocol v4. Looking at Xandra.Frame I find the request versions set to 0x03 and the response version set to 0x83 which indicates native protocol v3, see native_protocol_v3, section 2.1 version.

For native protocol v4 these should be set to 0x04 and 0x84 respectively, see native_protocol_v4, section 2.1 version. Grepping through the source code I cannot find any reference to the v4 version bits.

To me this seems to indicate that Xandra only speaks native protocol v3 with Cassandra. What am I missing?

Context: I would like to implement (and contribute) a native protocol v4 feature for Xandra, specifically allowing unset values for prepared queries, see CASSANDRA-7304: Ability to distinguish between NULL and UNSET values in Prepared Statements.

jvf commented 5 years ago

Does anyone have any information on this? If @lexmag or @whatyouhide do not have any time to answer maybe someone else is interested in this question and wants to take a look?

whatyouhide commented 5 years ago

@jvf I am aware this is a problem. There's other problems with Xandra as well like updating it to db_connection >= 2. @lexmag and I won't have time to fix this in the near future but if you're willing to contribute support for native protocol v4, I'd love to provide assistance.

jvf commented 5 years ago

@whatyouhide I would like to work on support for native protocol v4. I even got permission from to work to spend some time on this. Any assistance you can provide would be greatly appreciated!

whatyouhide commented 5 years ago

@jvf what kind of assistance do you need to start working on this? I'm @whatyouhide on IRC (#elixir-lang) and on Elixir's Slack, feel free to ping me there or shoot me an email.

jvf commented 5 years ago

@whatyouhide I will contact you.