search

whatyouhide / xandra

Fast, simple, and robust Cassandra/ScyllaDB driver for Elixir.
ISC License
406 stars 54 forks source link

Send discovered_nodes in bulk from control connection #299

Closed harunzengin closed 1 year ago

harunzengin commented 1 year ago

Introduces a new message {:discovered_hosts, [Host.t()]}. I wasn't so sure about whether we should introduce a new telemetry event for this, like :host_discovered. Not sure how useful it would be to be able to distinguish between a :host_added (from cassandra gossip) and :host_discovered (from peers table).

Closes https://github.com/lexhide/xandra/issues/296

whatyouhide commented 1 year ago

@harunzengin no need for a new Telemetry event. Let't just fire a bunch of :host_up events instead.

harunzengin commented 1 year ago

@harunzengin no need for a new Telemetry event. Let't just fire a bunch of :host_up events instead.

Shouldn't we fire :host_added as it is now? From :host_up I understand that the node was down and is up now.

whatyouhide commented 1 year ago

Sorry yes that's what I meant @harunzengin

harunzengin commented 1 year ago

@whatyouhide Done!