Closed LKTSNR closed 6 years ago
Same here
Same here
Thought it might be just me. I've disabled it for now.
I wonder, could this script be gifted to Tweeten to incorporate there? That's an extension that's essentially a glorified userscript for Tweetdeck--but it notably doesn't have this feature!
I was able to resolve by editing the script directly and removing lines 15 - 19 https://github.com/whawker/TweetDeck-Chrome-Trends/blob/master/tampermonkey.user.js#L15-L19
It seems a recent Tweetdeck update has removed the getColumnType
function from the column object prototype, with no obvious replacement. There is a field on the column object called model.type
but this didn't seem relevant in my (very limited) testing. So I just removed the override of isFilterable
function completely and it seems to work fine.
Boom! Well done. I just // d the offending lines, and I've got my trends back again. Many thanks!
Edwardo Jackson CEO & Founder CinemaDraft, LLC
cinemadraft.co
Twitter: https://twitter.com/PlayCinemaDraft
Instagram: https://www.instagram.com/playcinemadraft/
Facebook: https://www.facebook.com/cinemadraft/ Blog: https://medium.com/@cinemadraft Podcast: http://feeds.feedburner.com/CinemadraftPodcast Talk about the game with us in group chat! Join our Group Me: https://groupme.com/join_group/26063165/idoIV5
On Mon, Apr 16, 2018 at 5:07 PM, Evan Winstanley notifications@github.com wrote:
I was able to resolve by editing the script directly and removing lines 15
- 19 https://github.com/whawker/TweetDeck-Chrome-Trends/blob/ master/tampermonkey.user.js#L15-L19
It seems a recent Tweetdeck update has removed the getColumnType function from the column object prototype, with no obvious replacement. There is a field on the column object called model.type but this didn't seem relevant in my (very limited) testing. So I just removed the override of isFilterable function completely and it seems to work fine.
— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/whawker/TweetDeck-Chrome-Trends/issues/4#issuecomment-381788011, or mute the thread https://github.com/notifications/unsubscribe-auth/ATKa7NSsiHx0QIn4pLif4ZRjjOuctk0jks5tpTJIgaJpZM4TSsBs .
Sorry all, I'm on holiday at the moment without a laptop, so I can't make the changes.
If someone could open a PR, I'd be happy to merge!
Removing the lines 15 to 19 don't fix the problem to me. The trends are back but every column just keeps loading including the trend without the option to choose location.
@whawker Take your time and enjoy your holiday. We can wait.
@whawker PR created https://github.com/whawker/TweetDeck-Chrome-Trends/pull/5
Just double check what I'm doing is right, it's not totally clear to me what that method was doing 😰
Edit: I'm actually getting the same as @netocavalcanti now. It did temporarily fix the problem but I think TD must have made further updates that have broken the script even more.
Same now here @EvanWinstanley. Leave it to Twitter to break what doesn't need fixing...ugh
When you do get around to fixing it, thanks A LOT..
Hi all, this should be fixed now. If you open the Tampermonkey dashboard then trigger an update, the new version is 4.4.0
@whawker Working perfectly again. Thank you! Have a great week.
Thanks a lot @whawker!!
This error appears when trying to enter tweetdeck. After clicking on "Log in", you can enter, but the "Trends" column never loads.