search

whawker / TweetDeck-Chrome-Trends

A very unofficial TweetDeck extension to add a Trends column(s)
15 stars 1 forks source link

Remove isFilterable function override #5

Closed EvanWinstanley closed 6 years ago

EvanWinstanley commented 6 years ago

Remove the override of isFilterable function on the column prototype. Internally this was calling getColumnType - another function on the column prototype that TD seems to have removed recently. I couldn't find any obvious replacement for getColumnType and the script seemed to work when this function override was removed.

whawker commented 6 years ago

Fantastic thanks! Mind bumping the version on line 4 and 430 to 4.3.1? Otherwise it won't push the update to users.

EvanWinstanley commented 6 years ago

Hmmm... I think TD might have pushed more updates recently which have broken the script further. I'm getting a lot of console errors I wasn't getting yesterday, even with this change made.

Might be best to abandon this one, looks like further work is required.

whawker commented 6 years ago

Superseded by #6