search

whazzmaster / fitgem-client

Example client use of the fitgem oauth library to integrate with fitbit.com
MIT License
35 stars 9 forks source link

Upgrade to latest Rails/Ruby #4

Closed pinx closed 11 years ago

pinx commented 11 years ago

I'm a newbie, so bear with me. I tried to get the more obvious version conflicts out of the way. There is still a routing issue, which makes some of the tests fail.

I saw you made some preparations for subscriptions. I would very much like to get this working.

whazzmaster commented 11 years ago

Thanks for the request, Marcel. I'm finishing up some stuff for my day job and then I'll take a look at this on my holiday break. My first child is due any day now so if I don't get to it in the next week or so that's why. On an initial glance I like some of the changes but have a few suggestions:

  1. The diffs show whitespace differences on some lines
  2. You accidentally kept your consumer key/secret in the app_config.yml file
  3. It would awesome if the test changes could be broken out into a separate pull request

I haven't had time to keep updating this reference site with more examples of how to use fitgem in a Rails app. Any additional example content would be greatly appreciated!

pinx commented 11 years ago

Hi,

This was my first pull request, ever! I was a bit excited, and I am glad it went so well. Thanks for your support.

Congratulations with your first child. My oldest son is already 16, but I remember his birth like it was yesterday. I suppose you know where your priorities are, so I won't be expecting too much. No rush here; we will be off to Berlin between christmas and new year, so not much activity to be expected at this side of the ocean.

If there is a small thing I can ask you: could you have a look at the routes? It's probably something simple, but since I have just started with Rails, I don't understand all of it, yet. To comment on your suggestions:

  1. I think Rubymine cleaned up for me. Should I do something about it?
  2. Thanks.
  3. This will be a good exercise for me!

Some background: My wife works for a Dutch public health organization. She is planning to set up her own company on "quantified self". There is a site, similar to the old Google Health (patient1.nl), that could receive fitbit data. That is why I need the subscription function.

Thanks for your help, I hope I can contibute to your project .

Marcel van Pinxteren

Op donderdag 20 december 2012 schreef Zachery Moneypenny ( notifications@github.com) het volgende:

Thanks for the request, Marcel. I'm finishing up some stuff for my day job and then I'll take a look at this on my holiday break. My first child is due any day now so if I don't get to it in the next week or so that's why. On an initial glance I like some of the changes but have a few suggestions:

  1. The diffs show whitespace differences on some lines
  2. You accidentally kept your consumer key/secret in the app_config.yml file
  3. It would awesome if the test changes could be broken out into a separate pull request

I haven't had time to keep updating this reference site with more examples of how to use fitgem in a Rails app. Any additional example content would be greatly appreciated!

— Reply to this email directly or view it on GitHubhttps://github.com/whazzmaster/fitgem-client/pull/4#issuecomment-11587236.

Met vriendelijke groet,

Marcel van Pinxteren

Volg onze bouw op http://nieuwekampen.blogspot.com

whazzmaster commented 11 years ago

Hi Marcel- I processed your pull request plus a whole bunch of cleanup. I realized that when I switched over to a better model to represent the content (and integrate some backbone.js for the dynamic data) I failed to remove the old content structure and tests.

I'm going to continue to look at further cleanup I can do, but for now I've integrated your changes into master branch and added some new cleanup as well.