wheelhouseio / curriculum-github

5 stars 2 forks source link

Instruction Inconsistency in Section 7 & 8 - Users on Wrong Branch #176

Closed crichID closed 8 years ago

crichID commented 8 years ago

Feedback from learner:

In "Section 8: Working with Local Files", in the assignment subsection "Modifying Local Files", you do not mention to do this in the feature branch (as previously suggested in the videos). Therefore, I think most of the people will perform this staging and committing in the master branch. I think so, because in the previous assignment (subsection "Pulling Changes" in the "Section 7: The Workflow End-to-End"), people are asked to checkout to the master branch to retrieve the changes from the remote. Therefore, they would be already in the master branch.

If people perform the staging and commit in the master branch, then they will not be able to perform a subsequent assignment. The assignment ""Merging Local Changes" (also in "Section 8: Working with Local Files") asks to merge the local feature branch into the master one. And this can only be done if previous staging and committing has been done in the feature branch.

1point618 commented 8 years ago

Great point! This should definitely go on the list of things to change.