wheelhouseio / curriculum-github

5 stars 2 forks source link

No Validations in the Second Half of the Course #180

Closed 1point618 closed 8 years ago

1point618 commented 8 years ago

Hi @crichID and @johnpaulashenfelter.

In the second half of the GHfDevs course, there are no places where we validate work is done. Part of this is due to the fact that students are using the command line. However, there are plenty of spots where we ask the students to push their work to GitHub, where we could validate. They are using a GH Repo that they have created, so we don't have a webhook on the repo, which is why were don't currently validate in those situations.

After talking to @PeterBell, I wanted to bring up the idea of fixing this issue. There are three ways I could see to do this:

  1. When the student creates the Repo, we give them a webhook and instructions for how to add that to the repo.
  2. When the student creates the Repo, we ask them for the link to the Repo and use our permissions to add the webhook ourselves.
  3. We re-write the content so that the student continues to work on the Repo we generated for them.

And of course there is a 4th option, which is "do nothing, it's OK as is". I'm open to this possibility, but would personally prefer to as least consider that one of the other options might work for us.

This is both a content and technology issue. John, do you think from a technology standpoint that one or another of these options makes the most sense from the technology perspective? And Cynthia, what do you think generally of the goal of adding more validations to the course where we can and about the way to handle this from a content standpoint?

1point618 commented 8 years ago

Oh and to show my work, Issue #176 is what brought this to my attention. In the video in "merge local branches" we tell the student that a branch merged locally, once pushed, will also close a PR, but we never have the student create or close the PR, a clear case where if we had a webhook in the repo we could validate that the student is on the right track.

1point618 commented 8 years ago

Hey @johnpaulashenfelter, I'd love to get your feedback on the ideas above.