search

wheeyls / critical-css-server

Eliminate render-blocking CSS in above-the-fold content
MIT License
28 stars 6 forks source link

Replace criticalcss with penthouse #2

Closed josh-m-sharpe closed 7 years ago

josh-m-sharpe commented 7 years ago

Honestly, not sure i this is truly necessary. I did a lot of debugging and changing things both with here on the server with criticalcss/penthouse and in the ruby gem. The first working solution I got had this branch running (and I currently have it live in prod). I'm somewhat unfamiliar with the difference between criticalcss and penthouse - though, it seems that criticalcss hasn't seem a commit in almost a year and penthouse is more actively developed.

So, if you want to give it a shot and merge it, here ya go! :)

wheeyls commented 7 years ago

Interesting - you have this working in production now? I can pull it down and try it out.

Worth noting that the phantomjs project has been abandoned by it's maintainer; https://www.infoq.com/news/2017/04/Phantomjs-future-uncertain. Would be good to see which critical css libraries switch to chrome headless and migrate to that!

wheeyls commented 7 years ago

Got this merged and am using it in my production app; seems to be a pretty painless transition, thanks for your help!