search

whelandrew / URLShortener

0 stars 0 forks source link

React dependencies not specified in package.json #1

Closed el-guero-mero closed 5 years ago

el-guero-mero commented 5 years ago

There are two dependencies that are not specified in package.json file:

  1. react
  2. react-dom

Please include these in the package.json file. We should assume for the sake of review that a user would not have any pre-existing libraries installed ;)

whelandrew commented 5 years ago

Added and pushed. Thanks for noticing that! I forgot that my react is global on my computer. https://github.com/whelandrew/URLShortener

From: Mateo Nares Sent: Tuesday, October 22, 2019 9:14 AM To: whelandrew/URLShortener Cc: Subscribed Subject: [whelandrew/URLShortener] React dependencies not specified inpackage.json (#1)

There are two dependencies that are not specified in package.json file:

  1. react
  2. react-dom Please include these in the package.json file. We should assume for the sake of review that a user would not have any pre-existing libraries installed ;) — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe.
el-guero-mero commented 5 years ago

Great, thank you!