search

where-fore / rogue-wotlk

This is place for all things Rogue-Related in Wrath of the Lich King Classic. Inspired by Magey's previous work.
3 stars 0 forks source link

Critical Damage Stacking Formulas #31

Closed where-fore closed 1 year ago

where-fore commented 2 years ago

How do all sources of critical damage bonus stack together? What bonuses affect what damage?

RED = Relentless Earthstorm/Earthsiege Diamond PotW = Prey on the Weak talent

Poisons Crit multiplier = (1.5 IF(RED,1.03,1) IF(PotW,1.2,1)

Auto attacks: Crit multiplier = (2 + IF(Lethality,0.3,0) IF(PotW,1.2,IF(RED,1.03,1))) IF(RED,1.03,1) * IF(PotW,1.2,1)

Specials: Crit multiplier = (2 + IF(Lethality,0.3,0) IF(PotW,1.2,IF(RED,1.03,1))) IF(RED,1.03,1) * IF(PotW,1.2,1)

Individual Confirmations Just a single test with these should confirm it is working as intended. If it is broken, further testing is to be done.

where-fore commented 2 years ago

Testing Instructions:

Please set up a gearset with a single main-hand Worn Dagger, which you can get one of by starting a brand new level 1 rogue and mailing it to yourself. No procs or otherwise changing values of damage - no Warp-Spring Coil, no Hyjal rep rings, nothing that would modify the damage you deal some of the time.

Pick the exact same target for all the tests. Apply an Instant Poison to your main hand Worn Dagger.

Now you are to record a combat log of a handful of crits - autos and sinister strikes. Thanks to the Worn Dagger, you only need a very small sample size of around 10 critical hits.

Repeat. but add a critical damage variable. Make sure to record which logs have which variables. Once we have the raw .txt logs of each step, and the final result with all variables, we should be able to work out the formulas.

simonizeshow commented 2 years ago

Draklian provided test results, on 6/27, ver 3.4.0.44301. Twitch vod here: https://www.twitch.tv/videos/1516101417 WCL upload here: https://www.warcraftlogs.com/reports/1aP2fqtwjpQVmWBx/#type=damage-done&boss=0&difficulty=0

First fight: No RED, No PotW, No Lethality Second fight: RED, No PotW, No Lethality Third fight: No RED, PotW, No Lethality Fourth fight: RED, PotW, No Lethality. PotW is likely not active here due to equipping item and not healing to full before combat start. Fifth fight: RED, PotW, Lethality

Simonize conclusions:

I think this clearly shows: 2 1.2 = 2.4multiplier for PotW for melee and sinisters 2 1.2 1.03 = 2.472 multiplier for PotW + RED for melee 2 1.03 = 2.06 multiplier for RED for melee and sinisters ????? = 2.912 to 2.918 multiplier for RED+PotW+Lethality for sinisters. Cannot make a good guess at the formula. Data suggests multiplier between 2.912 and 2.918 for this.

I think sample size on poisons is a bit too small in this log to draw conclusion.

Cramer provided results WCL report: https://classic.warcraftlogs.com/reports/Fq4CdvfKA8Y27Lh9/#fight=2&type=damage-done

First two fights are no PotW, next fight has PotW. Using two different melee weapons so auto attack data is scuffed. using Wound Poison. wound poison has higher proc chance so it is easier to get data with.

Simonize conclusions:

This log has sufficient poison hits to draw conclusion from I think

I think this log shows 2 1.2 = 2.4 multiplier for PotW for sinisters 1.5 1.2 = 1.8 multiplier for PotW for poisons

simonizeshow commented 2 years ago

Draklian provided more data, here: https://www.warcraftlogs.com/reports/mA6aqxJBfCRHnZdj/#fight=4&type=damage-done&source=1

I will try to post my work later in spreadsheet format to show experimental data

Results and conclusion

Experimental Data for Sinister Strike Crit Multiplier

RED // Lethality // PotW // Experimental Result // Formula Result 1 // 0 // 0 // 2.06134 // 2.06 0 // 1 // 0 // 2.293673 // 2.3 0 // 0 // 1 // 2.400922 // 2.4 1 // 1 // 0 // 2.373391 // 2.37827 1 // 0 // 1 // 2.473852 // 2.472 0 // 1 // 1 // 2.822614 // 2.832 1 // 1 // 1 // 2.915878 // 2.91696

Formula consistent with all this data:

Crit multiplier = (2 + IF(Lethality,0.3,0) IF(PotW,1.2,IF(RED,1.03,1))) IF(RED,1.03,1) * IF(PotW,1.2,1)

this is consistent for data with auto attacks also where Lethality is always false.

if you change the initial "2" to "1.5", it is consistent for poisons as well where Lethality is also always false.

vigo2 commented 2 years ago

This is unchanged from TBC. With M for crit multipliers (e.g. "Base" 150%/200%, RED 103%, PotW 120%), and B for crit damage bonuses (e.g. "Base" 100%, Lethality 30%, Ruin 100%)

C = 1 + (Product of all M - 1) * (Sum of all B)

Examples:

Rogue with RED, PotW and Lethality C = 1 + (200% * 103% * 120% - 1) * (100% + 30%) = 1 + (247.2% - 1) * (130%) = 291.36%

Warlock with RED, Ruin C = 1 + (150% * 103% - 1) * (100% + 100%) = 1 + (154.5% - 1) * (200%) = 209%

Hunter with RED, Mortal Shots and Marked for Death C = 1 + (200% * 103% - 1) * (100% + 30% + 10%) = 1 + (206% - 1) * (140%) = 248.4%

This is the formula basically everyone outside the Simoverse was using, and which conveniently works for casters as well ;)

Troll's Beast Slaying, Hunter's Improved Tracking, and Paladin's Crusade now only increase damage vs. specified mob types, and no longer increase the critical damage as well.

Some GREP'ed Target/Spell/Damage/Raw Damage from logs:

"Bonechewer Scavenger","Frostbolt",3136,1393
"Bonechewer Evoker","Frostbolt",2707,1203
"Bonestripper Buzzard","Frostbolt",2935,1304
"Bonestripper Buzzard","Frostbolt",2893,1285

(Troll mage with Ice Shards and Spell Power for 150% critical strike damage bonus, vs. Humanoids and Beasts)

"Umbrafen Seer","Exorcism",1536,1024
"Umbrafen Oracle","Hammer of Wrath",1892,946
"Young Sporebat","Exorcism",1721,1147
"Umbraglow Stinger","Hammer of Wrath",1834,916

(Paladin with Crusade)

"Gordunni Elementalist","Arcane Shot",1647,663
"Gordunni Elementalist","Arcane Shot",1372,552
<Humanoid Tracking enabled>
"Gordunni Elementalist","Arcane Shot",1742,701
"Gordunni Elementalist","Arcane Shot",1451,584

(Hunter with Improved Tracking, RED, Mortal Shots and Marked for Death)