search

where-is-paul / matrix-factor

Code for providing incomplete factorizations of symmetric indefinite matrices.
MIT License
10 stars 8 forks source link

OSX build. #7

Closed dpo closed 8 years ago

dpo commented 8 years ago

A clang++ build is possible on OSX with these changes. A user should set MATLABDIR before invoking make. For example,

MATLABDIR=/usr/opt/matlab make

(on Linux) or

MATLABDIR=/Applications/Matlab/MATLAB_R2013b.app

(on OSX). On Windows, I'm not so sure.

where-is-paul commented 8 years ago

Hi Dominque,

I had to revert some of your changes to the makefile for ldl_driver. I am all for keeping the .o files to speed up compilation, but I couldn't get your change to work when the source directory had spaces in its path name ($(PWD) failed to escape the spaces). Even after I escaped the spaces, there were issues.

Two questions:

  1. What is the benefit of changing . to $(PWD)?
  2. Is there a way to make your changes work with spaces in the path of the current working directory?
dpo commented 8 years ago

I'll admit that I stopped worrying about paths with spaces many years ago! Feel free to restore . instead of $(PWD) if that resolves it.