Closed mjftw closed 10 months ago
Thanks for the detailed report 🙏 Will look into this straight away. Tbh, I havent tested with Create T3 App
at all. Prior to release we have tested with:
Hi, I've got an update for you!
Turns out this is my local env failing to work properly - certain I installed with npm i @whereby.com/browser-sdk@2.0.0-alpha26
(copied from install section of npm package), but looking at my package.json I was on 1.11.0 🤦🏽♂️
Nevermind! It seems to work now I've manually changed the version in package.json
Sorry for wasting both our time!
Well at least now you have a detailed report on what to look for if you see any other foolish developers raising issues like this!
Sorry for wasting both our time!
No worries, these reports are really valuable to us, and will help us iron out as much friction as possible for users to get going 🙏 Keep the feedback coming 💪
Aaaah okay I've worked out what happened!
I wasn't being (as much of) an idiot after all, although I should have checked package.json
.
Looks like if you run npm audit fix --force
it sends you back to 1.11.0
!
See output below:
~/l/whereby-browser-sandbox (create-t3-app)$ npm i @whereby.com/browser-sdk@2.0.0-beta1
npm WARN deprecated json3@3.3.2: Please use the native JSON object instead of JSON 3
added 75 packages, changed 1 package, and audited 443 packages in 9s
130 packages are looking for funding
run `npm fund` for details
8 vulnerabilities (1 moderate, 6 high, 1 critical)
To address all issues (including breaking changes), run:
npm audit fix --force
Run `npm audit` for details.
~/l/whereby-browser-sandbox (create-t3-app)$ grep '@whereby.com/browser-sdk' package.json
"@whereby.com/browser-sdk": "^2.0.0-beta1",
~/l/whereby-browser-sandbox (create-t3-app)$ npm audit fix --force
npm WARN using --force Recommended protections disabled.
npm WARN audit Updating @whereby.com/browser-sdk to 1.11.0, which is a SemVer major change.
removed 75 packages, changed 1 package, and audited 368 packages in 1s
121 packages are looking for funding
run `npm fund` for details
found 0 vulnerabilities
~/l/whereby-browser-sandbox (create-t3-app)$ grep '@whereby.com/browser-sdk' package.json
"@whereby.com/browser-sdk": "^1.11.0",
Thanks again. Seems like this is the expected behaviour of npm fix --force
actually. I have created an issue to fix these vulnerability warnings, which will hopefully prevent others falling into this trap.
Thank you 🙏🏽
I'm trying to use the Whereby Browser SDK react components, but having issues.
I've created a little sample project here to show the issues I'm seeing.
I made a create-t3-app and create-react-app to check if it was a NextJS specific issue. On both I am seeing the typings import error mentioned on https://github.com/whereby/browser-sdk/issues/99, but also I cannot import and use the Whereby components at all.
This might be some issue with my local environment if you are not able to reproduce the issue. If you have any ideas how to fix this would be a big help. I really do want to try out the Browser SDK to see if it could solve our issues at Multiverse, but currently I can't get it working!
Dev Environment
Installed whereby browser SDK with:
Create T3 App
Here's a version that uses a NextJS app, created with Create T3 App, like we use at Multiverse. https://github.com/mjftw/whereby-errors-sandbox/tree/create-t3-app
To use
My output
Terminal output:
Clientside screenshot![image](https://github.com/whereby/browser-sdk/assets/8429712/8555dbba-c8d0-4dfd-b6aa-a7c9c1fcd666)
Serverside rendering screenshot![image](https://github.com/whereby/browser-sdk/assets/8429712/5d945c8b-6ebf-4123-898f-e5b10c16aca7)
Create React App
And here's one where I used Create React App, just to see if it was a NextJS specific issue. https://github.com/mjftw/whereby-errors-sandbox/tree/create-react-app
To use
My output
Terminal output
Screenshot:![image](https://github.com/whereby/browser-sdk/assets/8429712/6453a825-fd82-4a70-b25f-20544b86257f)