whereby / browser-sdk

Browser SDK for Whereby Embedded
MIT License
24 stars 3 forks source link

Send a dummy insightsStats event to rtc stats #193

Closed thyal closed 8 months ago

thyal commented 8 months ago

Description

The participant insights on the dashboard requires a timeStamp to be able to display the timeline of events. RTC stats only sets the timeStamp property on the first insightsStats event. Since we are not sending these events from the SDK yet, this PR adds a dummy event, so that the timestamp gets populated.

Summary:

Related Issue:

Testing

  1. Start a session with a few clients
  2. Toggle microphone / camera from the SDK client a few times
  3. End the session
  4. Go to the insights dashboard and find the session
  5. Find the SDK participant, and verify that the timeline is correctly populated with the events

Screenshots/GIFs (if applicable)

Checklist

Dependency Updates

Reviewers

@havardholvik @kevinwhereby @nandito @thyal

Additional Information

thyal commented 8 months ago

Looks good ref our discussion. Would it be valuable to have an integration test asserting this?

Good shout. Added an assertion on the existing integration test for the doRtcAnalyticsCustomEventsInitialize fn