browser-sdk: update exports to use default name rather than import

whereby / sdk

MIT License

10 stars 2 forks source link

browser-sdk: update exports to use default name rather than import #280

Open remotezygote opened 3 months ago

remotezygote commented 3 months ago

Description

Summary:

Similar to this issue in next-auth: https://github.com/nextauthjs/next-auth/pull/8330

The exports as situated do not work with all bundlers/resolvers.

Related Issue:

n/a

Testing

Screenshots/GIFs (if applicable)

Checklist

[x] My code follows the project's coding standards.
[x] Prefixed the PR title and commit messages with the service or package name
[x] I have written unit tests (if applicable).
[x] I have updated the documentation (if applicable).
[x] By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.

Additional Information

changeset-bot[bot] commented 3 months ago

🦋 Changeset detected

Latest commit: 9443b259bc3bf143e177fd50d240f290ce072613

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

| Name | Type | | ------------------------ | ----- | | @whereby.com/browser-sdk | Minor |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

thyal commented 2 months ago

Hey 👋

Thanks for the PR! Sorry for the delay on this. The pipelines are not set up to work with forks of the repository, that's why this PR is failing. I'm going to look in to that + create a contribution guide. We do want to welcome contributions!

For now though, I just merged #307 , which was aimed at a different problem, but I also added the default export field there. It's released in v3.3.0. Let me know if that fixes the problem for you.