Closed thyal closed 3 months ago
Latest commit: 1fcfa6b65fc83fccf8dea10ac7e47a73ae88a261
The changes in this PR will be included in the next version bump.
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
Looks like it all functions well, I'm wondering though if we can make the initialisation part a bit nicer:
It looks like we already know the final aspect ratio / size of the video tiles before they have finished loading, so could we restrict them at that point rather than once the stream has been accepted and added to the dom?
One little comment about the initial render but happy to merge if you are! 🚀
Good catch. I've improved it now. From my testing it seems much better
Description
Adds participant menu to the grid component. This can be used in two ways: In the
renderParticipant
function where you can customise it and decide which elements to render, or, if not using the render prop, it can be disabled/enabled with theenableParticipantMenu
prop (defaults to true).Summary:
Related Issue:
Testing
Test the new grid stories. There's two stories - default and custom grid.
Screenshots/GIFs (if applicable)
Checklist
Additional Information