whereby / sdk

MIT License
10 stars 2 forks source link

common: Grid - Participant menu, render prop and maximize action #282

Closed thyal closed 3 months ago

thyal commented 3 months ago

Description

Adds participant menu to the grid component. This can be used in two ways: In the renderParticipant function where you can customise it and decide which elements to render, or, if not using the render prop, it can be disabled/enabled with the enableParticipantMenu prop (defaults to true).

Summary:

Related Issue:

Testing

Test the new grid stories. There's two stories - default and custom grid.

Screenshots/GIFs (if applicable)

Checklist

Additional Information

changeset-bot[bot] commented 3 months ago

🦋 Changeset detected

Latest commit: 1fcfa6b65fc83fccf8dea10ac7e47a73ae88a261

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages | Name | Type | | ------------------------ | ----- | | @whereby.com/core | Minor | | @whereby.com/browser-sdk | Minor |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

kevinwhereby commented 3 months ago

Looks like it all functions well, I'm wondering though if we can make the initialisation part a bit nicer: Kapture 2024-06-04 at 16 59 10

It looks like we already know the final aspect ratio / size of the video tiles before they have finished loading, so could we restrict them at that point rather than once the stream has been accepted and added to the dom?

thyal commented 3 months ago

One little comment about the initial render but happy to merge if you are! 🚀

Good catch. I've improved it now. From my testing it seems much better