whereby / sdk

MIT License
10 stars 2 forks source link

Change import to default in exports to ensure compatibility #286

Closed remotezygote closed 3 months ago

remotezygote commented 3 months ago

Description

Summary:

See https://github.com/nextauthjs/next-auth/pull/8330 for more details. Some bundlers and resolvers have issues with the import key in exports. The default key works the same and is better supported by tooling.

Related Issue:

None

Testing

Load this module using vite - after this, it works, before, it fails with a message like No known conditions for "./react" specifier in "@whereby.com/browser-sdk" package

Screenshots/GIFs (if applicable)

Checklist

Additional Information

changeset-bot[bot] commented 3 months ago

⚠️ No Changeset found

Latest commit: 262a13001a36230a2b0db08dadb77700edafe05a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR