core: remove node sdk startup logic

kevinwhereby commented 2 months ago

This is causing issues with the dial in worker, so let's instead add polyfills on that side to make it work more like the browser, rather than altering the sdk behaviour

Description

When I tried newer /core versions with the Dial In agent (it was on 0.9.1) it didn't like all the rejoin functionality we've added here.

Instead I figured it's nicer to make the node clients work as similarly to browser clients as possible, so I've polyfilled the required functionality on the node agent side and we can remove it from here

Summary:

Related Issue:

Testing

I've got a PR here updating the node agents: https://github.com/whereby/recording-service/pull/419 It shouldn't effect browser clients at all

Screenshots/GIFs (if applicable)

Checklist

[x] My code follows the project's coding standards.
[x] Prefixed the PR title and commit messages with the service or package name
[x] I have written unit tests (if applicable).
[x] I have updated the documentation (if applicable).
[x] By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.

Additional Information

changeset-bot[bot] commented 2 months ago

🦋 Changeset detected

Latest commit: e06697c7d41fe754a66e8e1c988dffe946a7fcb2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

| Name | Type | | ------------------------ | ----- | | @whereby.com/core | Minor | | @whereby.com/browser-sdk | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

kevinwhereby commented 2 months ago

/canary

github-actions[bot] commented 2 months ago

🚀 The canary releases have been published to npm.

You can test the releases by installing the newly published versions:

yarn add @whereby.com/browser-sdk@0.0.0-canary-20240618124326

yarn add @whereby.com/core@0.0.0-canary-20240618124326

whereby / sdk