whereby / sdk

MIT License
10 stars 2 forks source link

media: Fix issue with stream resolution on SFU #309

Closed havardholvik closed 2 months ago

havardholvik commented 2 months ago

Description

In many cases, updateStreamResolution is called before the consumer is ready. In order to avoid the integrating application needing to be aware of consumer state, we now keep track of streamId and resolution and apply the correct simulcast layer when the consumer is ready.

Testing

Will provide a PWA PR with manual test instructions.

Checklist

changeset-bot[bot] commented 2 months ago

🦋 Changeset detected

Latest commit: cc38ede6b079417df0fc3ad49aa3a8174fc0b834

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages | Name | Type | | ------------------------ | ----- | | @whereby.com/media | Patch | | @whereby.com/core | Patch | | @whereby.com/browser-sdk | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

havardholvik commented 2 months ago

/canary

github-actions[bot] commented 2 months ago

🚀 The canary releases have been published to npm.

You can test the releases by installing the newly published versions:

yarn add @whereby.com/browser-sdk@0.0.0-canary-20240627083256
yarn add @whereby.com/core@0.0.0-canary-20240627083256
yarn add @whereby.com/media@0.0.0-canary-20240627083256
havardholvik commented 2 months ago

/canary

github-actions[bot] commented 2 months ago

🚀 The canary releases have been published to npm.

You can test the releases by installing the newly published versions:

yarn add @whereby.com/browser-sdk@0.0.0-canary-20240628073036
yarn add @whereby.com/core@0.0.0-canary-20240628073036
yarn add @whereby.com/media@0.0.0-canary-20240628073036