Handle senders without track when replacing tracks in P2P - Githubissues

whereby / sdk

MIT License

10 stars 2 forks source link

Handle senders without track when replacing tracks in P2P #313

Closed pnts-se-whereby closed 2 months ago

pnts-se-whereby commented 2 months ago

Description

Summary:

We iterate over all RTCRtpSenders. We expect all to have a track but the track attribute is null if the sender is not transmitting. https://developer.mozilla.org/en-US/docs/Web/API/RTCRtpSender/track

Related Issue:

Testing

Screenshots/GIFs (if applicable)

Checklist

[x] My code follows the project's coding standards.
[x] Prefixed the PR title and commit messages with the service or package name
[ ] I have written unit tests (if applicable).
[ ] I have updated the documentation (if applicable).
[x] By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.

Additional Information

changeset-bot[bot] commented 2 months ago

🦋 Changeset detected

Latest commit: e5e04f976d680d6e9671337d2367fd9fd16122fc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages

| Name | Type | | ------------------------ | ----- | | @whereby.com/media | Patch | | @whereby.com/core | Patch | | @whereby.com/browser-sdk | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR