Closed nandito closed 1 month ago
Latest commit: d7bad4d59641b95c3cc77ba4b4ee0c8f21ca2fa9
The changes in this PR will be included in the next version bump.
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
Description
Summary:
Extend the
selectShouldConnectRoom
to check if there's a room connection error and returnfalse
if there is. This should prevent thejoin_room
loop if the room is full.Related Issue:
Testing
normal
size room as a host.env
file with your local-stack endpoints to test against local-stackyarn build
yarn dev:sample-app
disconnected
status and there's no sign of infinitejoin_room
call loop in the ws messages.Screenshots/GIFs (if applicable)
Checklist
Additional Information
There are scenarios where the
join_room
gets an error. One of them isroom_full
, but the reason can be the free trial experied, or meeting exhausted (i.e. time limit reached) or missing host, etc. As I see, currently this error state is not exposed in theuseRoomConnection
'sstate
. This is something we can/could improve.