search

whereby / sdk

MIT License
12 stars 4 forks source link

media: handle sdp errors #459

Closed geirbakke closed 4 weeks ago

geirbakke commented 1 month ago

Description

This PR adds an option to clean sdp before setLocalDescription, hopefully working around browser bugs like: https://issues.webrtc.org/issues/41480892 (and a similar one on Firefox) It adds events so we can track these kind of errors in our apps It removes the pendingOffer logic as that was a workaround for a bug long time ago, and interfered with the tracking/events, and makes sure the offer isn't sent to remote end before working locally.

Testing instructions in PWA PR

changeset-bot[bot] commented 1 month ago

🦋 Changeset detected

Latest commit: 0fa77c4c858f30f8f19728a7f207cdd1a3c55018

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages | Name | Type | | ----------------------------- | ----- | | @whereby.com/media | Minor | | @whereby.com/core | Patch | | @whereby.com/browser-sdk | Patch | | @whereby.com/react-native-sdk | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

geirbakke commented 1 month ago

/canary

github-actions[bot] commented 1 month ago

🚀 The canary releases have been published to npm.

You can test the releases by installing the newly published versions:

yarn add @whereby.com/browser-sdk@0.0.0-canary-20241031135851
yarn add @whereby.com/core@0.0.0-canary-20241031135851
yarn add @whereby.com/media@0.0.0-canary-20241031135851
yarn add @whereby.com/react-native-sdk@0.0.0-canary-20241031135851
geirbakke commented 1 month ago

/canary

github-actions[bot] commented 1 month ago

🚀 The canary releases have been published to npm.

You can test the releases by installing the newly published versions:

yarn add @whereby.com/browser-sdk@0.0.0-canary-20241031194056
yarn add @whereby.com/core@0.0.0-canary-20241031194056
yarn add @whereby.com/media@0.0.0-canary-20241031194056
yarn add @whereby.com/react-native-sdk@0.0.0-canary-20241031194056
geirbakke commented 1 month ago

/canary

github-actions[bot] commented 1 month ago

🚀 The canary releases have been published to npm.

You can test the releases by installing the newly published versions:

yarn add @whereby.com/browser-sdk@0.0.0-canary-20241101120009
yarn add @whereby.com/core@0.0.0-canary-20241101120009
yarn add @whereby.com/media@0.0.0-canary-20241101120009
yarn add @whereby.com/react-native-sdk@0.0.0-canary-20241101120009