wheremyfoodat / Panda3DS

HLE 3DS emulator
https://panda3ds.com/
GNU General Public License v3.0
790 stars 57 forks source link

Refactor `Rust::Result` into `std::expected` #456

Closed Wunkolo closed 4 months ago

Wunkolo commented 4 months ago

The standard library already has support for this type as of C++23: https://en.cppreference.com/w/cpp/header/expected

This is also supported by all major compilers

This bumps the project up to C++23.

wheremyfoodat commented 4 months ago

The NDK strives for equality, for it hates everyone equally.

Wunkolo commented 4 months ago

Windows passes just fine. Android fails due to missing the header entirely. The other builds fail due to a libstdc++ issue(https://github.com/llvm/llvm-project/issues/62801). Closing for now!

wheremyfoodat commented 4 months ago

Speaking of libstdc++ issues, shout out Github for closing this issue https://github.com/actions/runner-images/issues/8659