Fix AES-CTR decryption for non-NCCHKey0 games

wheremyfoodat / Panda3DS

HLE 3DS emulator

https://panda3ds.com/

GNU General Public License v3.0

801 stars 58 forks source link

Fix AES-CTR decryption for non-NCCHKey0 games #532

Closed wheremyfoodat closed 3 weeks ago

wheremyfoodat commented 3 weeks ago

Fixes several encrypted dumps for later games not working, tested with Glory of Generals and Ninja Usagimaru. Likely fixes other games reported to be broken with encrypted dumps, such as Luigi's Mansion (cc @Adamillo If you could test it pretty please)

Adamillo commented 3 weeks ago

Sure thing! I can test it tomorrow!

wheremyfoodat commented 3 weeks ago

Implementing NCCH version 1 is also a pending issue since it affects the AES IV, though I have still not found a game that uses that. Might score with Luigi's Mansion though if it still doesn't work after this.