search

whereswaldon / kfreestyle2d

Unofficial Kinesis Freestyle 2 Userspace Linux Driver
MIT License
76 stars 21 forks source link

Thank you #9

Open javl opened 5 years ago

javl commented 5 years ago

Not an issue, but a thank you for creating and sharing this driver! I just got a second hand Freestyle (not the v2, and a mac version actually) and was kind of bummed the media keys didn't work on Debian. I've forked your project and adapted the key mapping to work with this keyboard (apparently this older model uses some other key codes) and all of them work perfectly now (now to remap those silly copy-paste shortcut buttons somehow).

whereswaldon commented 4 years ago

@javl You are super welcome! I'm sorry that I missed this issue before. I'm doing most of my work on sourcehut nowadays, and I guess I missed the email from GitHub.

Anyway, it's cool that you were able to adapt this to the mac version of the keyboard! I was wondering what you'd think of combining the key table that you have with the one here. It seems that you had to change the locations of NEXT, and PREV by a few columns in the key table. What would you think about simply repeating them?

This line: https://github.com/whereswaldon/kfreestyle2d/compare/master...javl:master?diff=unified#diff-2e82c9b82166bf88ba479ed41656654bL35

could instead read:

 /* B */    0,    0,    0, NEXT, PREV, NEXT, PREV,    0, EJCT,    0,    0,    0,    0,    0,    0,    0,

With that modification, I think that this driver would simply work for the mac keyboard in addition to the Windows and Pro versions of the keyboard.

If that's the case, would you be interested in submitting a PR to add support for the mac edition?

I really appreciate the attribution that you gave in your fork's README by the way.

javl commented 4 years ago

Sorry, I actually stopped using that keyboard a while ago. Couldn't really get used to it (partly because it was too worn down). I kept my edit online for others that still want to use it with Linux, but I can't make the change and test anymore.

chaypaterson commented 4 months ago

Also not an issue but thank you, this was exactly my use case (Freestyle 2 on Debian) and it works really well.

Sometimes requires a reboot after a kernel update, I think? Can try to reproduce and test.

Thank you!

whereswaldon commented 4 months ago

I'm very glad it's useful to you.

Sometimes requires a reboot after a kernel update, I think? Can try to reproduce and test.

Hmm. That would be unexpected. Please do try to gather more info about that and put it in a new issue.