whereuat / whereuat-android

The Android app for whereu@.
Apache License 2.0
2 stars 0 forks source link

Stupids #42

Open kangp3 opened 8 years ago

kangp3 commented 8 years ago
kangp3 commented 8 years ago

Lots of random whitespace at the end of MainActivity

juliusiv commented 8 years ago

line 23 in Constants is one character too long

kangp3 commented 8 years ago

Change the names of the BroadcastReceivers to match each other. LoginActivity uses *BroadcastReceiver while MainActivity uses *Receiver. Keep in mind that ContactReceiver class is not a BroadcastReceiver. May want to change name of that class as well.

kangp3 commented 8 years ago

mContext unused in ContactRetriever

kangp3 commented 8 years ago

Maybe make the variable names more consistent in ContactRetriever (i.e. mContactID, mContactName, mContactPhoneNumber)

kangp3 commented 8 years ago

Get rid of the testing project for com.whereuat.whereu

kangp3 commented 8 years ago

Database name in WhereuatDbHelper should be lowercase w whereuat.db.

juliusiv commented 8 years ago

there's an unused import in MainActivity, android.os.Build

juliusiv commented 8 years ago

@drawable/textinputborder should be @drawable/text_input_border to conform to style standards

juliusiv commented 8 years ago

The arguments to the QueryCommand constructor are styled weirdly.

juliusiv commented 8 years ago

Remove unused imports in ContactCardCursorAdaptor

juliusiv commented 8 years ago

Remove unnecessary Integer boxing in ContactCardCursorAdaptor

kangp3 commented 8 years ago

Move request code for the ContactReceiver to Constants. (see startActivityForResult call in MainActivity and switch statement in ContactReceiver constructor)

kangp3 commented 8 years ago

Latitude and longitude are extracted from the cursor twice when finding the nearest key location

juliusiv commented 8 years ago

s/savedInstanceState/saved_instance_state in MainActivity

juliusiv commented 8 years ago
<activity
            android:name=".LoginActivity"
            android:screenOrientation="portrait"
            android:theme="@style/AppTheme" />
juliusiv commented 8 years ago

Fix redundant Cursor cast in MainActivity

juliusiv commented 8 years ago

unnecessary parens on lines 56 and 66 in PendingRequestAdapter

kangp3 commented 8 years ago

Comment for createAtRequestAction says @response