Open kangp3 opened 8 years ago
Lots of random whitespace at the end of MainActivity
line 23 in Constants
is one character too long
Change the names of the BroadcastReceiver
s to match each other. LoginActivity
uses *BroadcastReceiver
while MainActivity
uses *Receiver
. Keep in mind that ContactReceiver
class is not a BroadcastReceiver
. May want to change name of that class as well.
mContext
unused in ContactRetriever
Maybe make the variable names more consistent in ContactRetriever
(i.e. mContactID
, mContactName
, mContactPhoneNumber
)
Get rid of the testing project for com.whereuat.whereu
Database name in WhereuatDbHelper
should be lowercase w whereuat.db
.
there's an unused import in MainActivity
, android.os.Build
@drawable/textinputborder
should be @drawable/text_input_border
to conform to style standards
The arguments to the QueryCommand
constructor are styled weirdly.
Remove unused imports in ContactCardCursorAdaptor
Remove unnecessary Integer boxing in ContactCardCursorAdaptor
Move request code for the ContactReceiver
to Constants
. (see startActivityForResult
call in MainActivity
and switch
statement in ContactReceiver
constructor)
Latitude and longitude are extracted from the cursor twice when finding the nearest key location
s/savedInstanceState/saved_instance_state in MainActivity
<activity
android:name=".LoginActivity"
android:screenOrientation="portrait"
android:theme="@style/AppTheme" />
Fix redundant Cursor
cast in MainActivity
unnecessary parens on lines 56 and 66 in PendingRequestAdapter
Comment for createAtRequestAction
says @response
RouterActivity
in the manifestaddContact
function inMainActivity
has no space in between the parameters and the{