search

wheybags / freeablo

[ARCHIVED] Modern reimplementation of the Diablo 1 game engine
GNU General Public License v3.0
2.16k stars 193 forks source link

proper direction type #327

Closed wheybags closed 6 years ago

wheybags commented 6 years ago

We just use an into for direction, where the values 0-7 encode the compass directions. This is what enums are for :p

Predelnik commented 6 years ago

Also it'd be nice to synchronize with Diablo's enum used for direction (https://github.com/sanctuary/notes/blob/c6779ad795fc78efe515dd48f55901ef7642fb95/enums.h#L67) I encountered it during item drop, if you click on player's tile it defaults to 0 in Diablo direction, but in Freeablo it's 7. (https://github.com/wheybags/freeablo/blob/2e817003b13adba8911489a04c2f215074f57e28/apps/freeablo/faworld/player.cpp#L258) That's not a big thing of course but maybe there will be similar problems with default direction along the way.