search

wheybags / freeablo

[ARCHIVED] Modern reimplementation of the Diablo 1 game engine
GNU General Public License v3.0
2.16k stars 195 forks source link

Add MD5 validation #448

Closed vieiraa closed 4 years ago

vieiraa commented 4 years ago

Fixes #427

vieiraa commented 4 years ago

I just realized that there is a md5 implementation already in components/misc. @wheybags, would it be OK to replace the current implementation with a Boost based one?

wheybags commented 4 years ago

Hi @vieiraa. Sorry for the long dfelay getting back to you. This prohject has been kind of sleeping for a while, but I've now arranged with my employer to work part time. I should be putting in around 2-3 days full time on freeablo for the next while, so there will be a lot more responsiveness and activity around here from now on :)

As for the implementation, I'd actually prefer to get rid of boost, instead of increasing our usage of it. However, as-is, this is significantly better than nothing, so I will go ahead and merge it anyway for now. Maybe you could make a follow up PR that switches the code to use our MD5 implementation?

Also, for future reference, the CI build failed on format checking your code, see here. The error message includes instructions on how to fix it automatically. I went ahead and committed those format changes to your branch here: https://github.com/wheybags/freeablo/pull/448/commits/15c6151ebe3ccf97787b2e21408b918970f5a42a

Thanks for the help, and please fetl free to stick around! :)