wheybags / freeablo

[ARCHIVED] Modern reimplementation of the Diablo 1 game engine
GNU General Public License v3.0
2.16k stars 195 forks source link

Reduce components visibility #469 #470

Closed akuskis closed 4 years ago

akuskis commented 4 years ago

This one should reduce visibility of freeablo/components, to fix issue #469

wheybags commented 4 years ago

Would it be a better solution to just rename our header to fa_audio.h or something like that?

akuskis commented 4 years ago

If you are fine with that, then I can rework it. Why I didn't rename it and only reduced scope, because there can be other situations like this.

wheybags commented 4 years ago

Well, even with the reduced scope, it can still happen that there is a collision in a module that actually needs both headers. We should be making sure our header names are un-generic enough that they're unlikely to cause collisions.

akuskis commented 4 years ago

Updated

wheybags commented 4 years ago

Cool, thanks!