search

wheybags / freeablo

[ARCHIVED] Modern reimplementation of the Diablo 1 game engine
GNU General Public License v3.0
2.16k stars 195 forks source link

regarding issue #491- pepin healing #493

Closed neveza closed 4 years ago

neveza commented 4 years ago

for issue #491 - added heal function and sound for pepin heal option. Also added a heal function with int32_t parameter to specify how much health, mostly for debugging, but may be useful for potions and spells future implementation

wheybags commented 4 years ago

Hi @neveza, thanks for the PR! I made one small tweak to the Actor::heal() function. I changed it to call MaxCurrentItem::add, as this will make sure it stays in bounds. Previously, the function could heal you to over max health.

Also, you may have noticed that the continuous integration failed: https://travis-ci.org/github/wheybags/freeablo/builds/689485091?utm_source=github_status&utm_medium=notification

It was just a minor formatting faliure, if you click into the clang-format job that failed and look at its output, you can see that it provides a diff to automatically fix the problem (but it's fine this time, my change ovewrote the bad line anyway).