Convert specs to RSpec 2.99.2 syntax with Transpec

[rabbitt]

This conversion is done by Transpec 3.0.7 with the following command: transpec -f

• 77 conversions from: Klass.any_instance.should_receive(:message) to: expect_any_instance_of(Klass).to receive(:message)
• 49 conversions from: obj.should_receive(:message) to: expect(obj).to receive(:message)
• 19 conversions from: be_true to: be_truthy
• 12 conversions from: be_false to: be_falsey
• 8 conversions from: obj.stub(:message) to: allow(obj).to receive(:message)
• 5 conversions from: Klass.any_instance.should_not_receive(:message) to: expect_any_instance_of(Klass).not_to receive(:message)
• 2 conversions from: obj.should to: expect(obj).to
• 2 conversions from: obj.should_not_receive(:message) to: expect(obj).not_to receive(:message)
• 1 conversion from: Klass.any_instance.stub(:message) to: allow_any_instance_of(Klass).to receive(:message)
• 1 conversion from: allow_any_instance_of(Klass).to receive(:message) { |arg| } to: allow_any_instance_of(Klass).to receive(:message) { |instance, arg| }
• 1 conversion from: expect { }.not_to raise_error(SpecificErrorClass) to: expect { }.not_to raise_error
• 1 addition of: RSpec.configure { |c| c.mock_with :rspec { |m| m.yield_receiver_to_any_instance_implementation_blocks = true } }

For more details: https://github.com/yujinakayama/transpec#supported-conversions

[coveralls]

Coverage remained the same at 99.8% when pulling eba9cfa3053fd71cccb2f73bf10c3ef2bbab5a49 on rabbitt:spec-updates into 7a7b88b1b0d6b275b9cd1ca7316cc8aa5bb3657b on whichdigital:master.

[rabbitt]

thoughts..?

[andyjeffries]

Merged manually as "We can’t automatically merge this pull request.". Happy with the PR itself, thank you.