whichsteveyp / react-localize

A simple context wrapper and text localization component for localizing strings.
ISC License
34 stars 11 forks source link

Provide ability to use empty string as translation #80

Closed yankouskia closed 5 years ago

yankouskia commented 5 years ago

@sprjr could you please take a look asap? very important feature for our team, we rely on this library for localization

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 549


Totals Coverage Status
Change from base Build 484: 1.4%
Covered Lines: 51
Relevant Lines: 58

💛 - Coveralls
marlonpp commented 5 years ago

@yankouskia it looks good to me, could you add a commit to bump the version as well. A patch release would be good enough.

whichsteveyp commented 5 years ago

Am driving cross country currently, but if @marlonpp doesn’t have publish access I can pull over and do a release!

Sent from my iPhone

On Jul 12, 2019, at 9:05 PM, marlonpp notifications@github.com wrote:

@yankouskia it looks good to me, could you add a commit to bump the version as well. A patch release would be good enough.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

marlonpp commented 5 years ago

I do have publish access!

yankouskia commented 5 years ago

@marlonpp could you please take a look if I have done it correctly?

marlonpp commented 5 years ago

Should be published now. Thanks for contributing!

yankouskia commented 5 years ago

@marlonpp thank you!

whichsteveyp commented 5 years ago

Minor note, just realized that we incidentally updated a few dependencies in the yarn.lock file as well. I assume if things are unchanged we're all set, but leaving a comment here just as a reminder in the event something else was impacted by that.

yankouskia commented 5 years ago

@sprjr packages are not changed. Such things happens when package.json and yarn.lock are inconsistent. I have double check deps, there are all related to dev deps, and mostly to rollup-plugin-babel. When this package was updated, yarn.lock has not been updated